This repository has been archived by the owner on May 18, 2020. It is now read-only.
Fix all-in-one start failed at k8s 1.16 #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuya Yoshida <boyoyon894@gmail.com>
|
plz update minikube&kubectl on travis ci. curl -Lo minikube https://storage.googleapis.com/minikube/releases/v0.25.0/minikube-linux-amd64 && chmod +x minikube
# now v1.4.0
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.9.0/bin/linux/amd64/kubectl && chmod +x kubectl
# now v1.16.0I think it should be done with another pull request, because the problem is big..... |
pavolloffay
reviewed
Oct 11, 2019
| @@ -15,7 +15,7 @@ | |||
| apiVersion: v1 | |||
| kind: List | |||
| items: | |||
| - apiVersion: extensions/v1beta1 | |||
| - apiVersion: apps/v1 | |||
There was a problem hiding this comment.
Would this cause failing in older k8s versions? Is extensions/v1beta1 supported in k8s 1.16?
This repository is in maintenance mode. However, if you submit a PR we most likely will accept it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #120
Short description of the changes
Change jaeger-all-in-one-template.yml according to kubernates 1.16 api