Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate buckets support for Tally Timer #67

Open
objectiser opened this issue Dec 7, 2018 · 0 comments
Open

Investigate buckets support for Tally Timer #67

objectiser opened this issue Dec 7, 2018 · 0 comments

Comments

@objectiser
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

With #63 it is now possible to define Histograms with buckets - but also define duration based buckets for the Timer metric type.

Problem - what in Jaeger blocks you from solving the requirement?

The buckets are being used with the Tally Histogram type - but it appears the Tally Timer type does not enable buckets to be defined.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Either buckets will have to be ignored for Tally impl (with a warning being produced?), or the underlying representation should be changed to a Tally Histogram with DurationBuckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant