From 54e25905eef19baafa7080a02702aea24fc7da55 Mon Sep 17 00:00:00 2001 From: Jared Tan Date: Tue, 13 Aug 2024 18:43:02 +0800 Subject: [PATCH] polish review --- cmd/es-rollover/app/init/flags.go | 1 - cmd/esmapping-generator/app/flags.go | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/es-rollover/app/init/flags.go b/cmd/es-rollover/app/init/flags.go index 3ea451cfedb..e1b5430f709 100644 --- a/cmd/es-rollover/app/init/flags.go +++ b/cmd/es-rollover/app/init/flags.go @@ -62,7 +62,6 @@ func (*Config) AddFlags(flags *flag.FlagSet) { // InitFromViper initializes config from viper.Viper. func (c *Config) InitFromViper(v *viper.Viper) { - deprecatedNumShards := v.GetInt(shards) deprecatedReplicaShards := v.GetInt(replicas) diff --git a/cmd/esmapping-generator/app/flags.go b/cmd/esmapping-generator/app/flags.go index 5afd150656e..fc69f15f77e 100644 --- a/cmd/esmapping-generator/app/flags.go +++ b/cmd/esmapping-generator/app/flags.go @@ -15,9 +15,11 @@ package app import ( - "github.com/jaegertracing/jaeger/pkg/es/config" - "github.com/spf13/cobra" "log" + + "github.com/spf13/cobra" + + "github.com/jaegertracing/jaeger/pkg/es/config" ) // Options represent configurable parameters for jaeger-esmapping-generator