Skip to content

Commit

Permalink
Parallelize the unit tests (#6191)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #6111 

## Description of the changes
- Added t.parallel to tests where it made significant improvement 

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
  • Loading branch information
chahatsagarmain authored Nov 11, 2024
1 parent e2067ef commit 851a1f8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions cmd/agent/app/builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ func TestCreateCollectorProxy(t *testing.T) {

for _, test := range tests {
t.Run("", func(t *testing.T) {
t.Parallel()
flags := &flag.FlagSet{}
grpc.AddFlags(flags)
reporter.AddFlags(flags)
Expand Down
6 changes: 4 additions & 2 deletions cmd/agent/app/reporter/grpc/builder_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,12 @@ func TestProxyClientTLS(t *testing.T) {
expectError: false,
},
}
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
var opts []grpc.ServerOption
if test.serverTLS.Enabled {
tlsCfg, err := test.serverTLS.Config(zap.NewNop())
Expand Down

0 comments on commit 851a1f8

Please sign in to comment.