Address Feedback From PR Review

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
jaegertracing · Nov 7, 2024 · e3a8487 · e3a8487
1 parent 97af5de
commit e3a8487
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/cmd/jaeger/internal/extension/jaegerstorage/factoryadapter/reader.go b/cmd/jaeger/internal/extension/jaegerstorage/factoryadapter/reader.go
@@ -21,11 +21,10 @@ type TraceReader struct {
 }
 
 func GetV1Reader(reader spanstore.Reader) (spanstore_v1.Reader, error) {
-	tr, ok := reader.(*TraceReader)
-	if !ok {
-		return nil, ErrV1ReaderNotAvailable
+	if tr, ok := reader.(*TraceReader); ok {
+		return tr.spanReader, nil
 	}
-	return tr.spanReader, nil
+	return nil, ErrV1ReaderNotAvailable
 }
 
 func NewTraceReader(spanReader spanstore_v1.Reader) *TraceReader {