Standardized tags

jaegertracing · Jan 11, 2025 · ed98b7d · ed98b7d
1 parent 980dc31
commit ed98b7d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/cmd/collector/app/span_processor.go b/cmd/collector/app/span_processor.go
@@ -237,7 +237,7 @@ func (sp *spanProcessor) enqueueSpan(span *model.Span, originalFormat processor.
 	}
 
 	// add format tag
-	span.Tags = append(span.Tags, model.String("internal.span.format", string(originalFormat)))
+	span.Tags = append(span.Tags, model.String("@jaeger@format", string(originalFormat)))
 
 	item := queueItem{
 		queuedTime: time.Now(),

diff --git a/internal/jptrace/warning.go b/internal/jptrace/warning.go
@@ -13,7 +13,7 @@ const (
 	// store various warnings produced from transformations,
 	// such as inbound sanitizers and outbound adjusters.
 	// The value type of the attribute is a string slice.
-	WarningsAttribute = "jaeger.internal.warnings"
+	WarningsAttribute = "@jaeger@warnings"
 )
 
 func AddWarnings(span ptrace.Span, warnings ...string) {

diff --git a/internal/jptrace/warning_test.go b/internal/jptrace/warning_test.go
@@ -42,13 +42,13 @@ func TestAddWarning(t *testing.T) {
 			span := ptrace.NewSpan()
 			attrs := span.Attributes()
 			if test.existing != nil {
-				warnings := attrs.PutEmptySlice("jaeger.internal.warnings")
+				warnings := attrs.PutEmptySlice("@jaeger@warnings")
 				for _, warn := range test.existing {
 					warnings.AppendEmpty().SetStr(warn)
 				}
 			}
 			AddWarnings(span, test.newWarn)
-			warnings, ok := attrs.Get("jaeger.internal.warnings")
+			warnings, ok := attrs.Get("@jaeger@warnings")
 			assert.True(t, ok)
 			assert.Equal(t, len(test.expected), warnings.Slice().Len())
 			for i, expectedWarn := range test.expected {
@@ -61,7 +61,7 @@ func TestAddWarning(t *testing.T) {
 func TestAddWarning_MultipleWarnings(t *testing.T) {
 	span := ptrace.NewSpan()
 	AddWarnings(span, "warning-1", "warning-2")
-	warnings, ok := span.Attributes().Get("jaeger.internal.warnings")
+	warnings, ok := span.Attributes().Get("@jaeger@warnings")
 	require.True(t, ok)
 	require.Equal(t, "warning-1", warnings.Slice().At(0).Str())
 	require.Equal(t, "warning-2", warnings.Slice().At(1).Str())
@@ -94,7 +94,7 @@ func TestGetWarnings(t *testing.T) {
 			span := ptrace.NewSpan()
 			attrs := span.Attributes()
 			if test.existing != nil {
-				warnings := attrs.PutEmptySlice("jaeger.internal.warnings")
+				warnings := attrs.PutEmptySlice("@jaeger@warnings")
 				for _, warn := range test.existing {
 					warnings.AppendEmpty().SetStr(warn)
 				}