Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Align Badger Storage Config With OTEL #5926

Closed
6 tasks done
mahadzaryab1 opened this issue Sep 2, 2024 · 0 comments · Fixed by #5927
Closed
6 tasks done

[jaeger-v2] Align Badger Storage Config With OTEL #5926

mahadzaryab1 opened this issue Sep 2, 2024 · 0 comments · Fixed by #5927
Labels
area/otel enhancement storage/badger Issues related to badger storage v2

Comments

@mahadzaryab1
Copy link
Contributor

mahadzaryab1 commented Sep 2, 2024 •
edited
Loading

Requirement

In this issue, we want to align the configuration for badger storage with OTEL (part of #5229)

Tasks / outcomes

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
  • Configs implement Validate()
  • Configs via YAML support the same defaults as in jaeger-v1
  • Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc. (N/A)
  • Configuration looks "logical" and properly grouped, not flattened with long weird names
  • We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
@dosubot dosubot bot added area/otel storage/badger Issues related to badger storage v2 labels Sep 2, 2024
@mahadzaryab1 mahadzaryab1 mentioned this issue Sep 2, 2024
Merged
4 tasks
@yurishkuro yurishkuro mentioned this issue Sep 3, 2024
Merged
yurishkuro added a commit that referenced this issue Sep 4, 2024
@yurishkuro
Remove unused "namespace" field from Badger config (#5929)
7a8fe39 
## Which problem is this PR solving?
- NamespaceConfig had a private `namespace` field which is not necessary
- Part of #5926

## Description of the changes
- Remove the field, clean up the tests

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
@mahadzaryab1 mahadzaryab1 mentioned this issue Sep 5, 2024
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Sep 5, 2024
@mahadzaryab1
[jaeger-v2] Consolidate Options And NamespaceConfig For Badger Storage (
978ecbf 
#5937)

## Which problem is this PR solving?
- Part of #5926

## Description of the changes
- Removed the `Options` struct and renamed `NamespaceConfig` to
`Namespace` for Badger Storage
- Moved v2-related configuration items to `config.go` while leaving v1
cli flags in `options.go`

## How was this change tested?
- CI

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@yurishkuro yurishkuro mentioned this issue Sep 25, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/otel enhancement storage/badger Issues related to badger storage v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jaeger-v2] Add Validation And Comments to Badger Storage Config mahadzaryab1/jaeger
1 participant
@mahadzaryab1