Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM is broken by OTEL's new version #5982

Closed
3 tasks
yurishkuro opened this issue Sep 13, 2024 · 5 comments · Fixed by #6007
Closed
3 tasks

SPM is broken by OTEL's new version #5982

yurishkuro opened this issue Sep 13, 2024 · 5 comments · Fixed by #6007
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

The PR #5968 is trying to upgrade to v0.109 and the SPM e2e test is consistently failing. It could be related to these breaking changes :

spanmetricsconnector:

  • Improve consistency between metrics generated by spanmetricsconnector. Added traces.span.metrics as default namespace (#33227, #32818)
  • Default namespace for the generated metrics is traces.span.metrics now. | The deprecated metrics are: calls, duration and events. | The feature flag connector.spanmetrics.legacyLatencyMetricNames was added to revert the behavior.

Tasks:

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Sep 13, 2024
@dosubot dosubot bot added area/otel changelog:breaking-change Change that is breaking public APIs or established behavior labels Sep 13, 2024
@FlamingSaint
Copy link
Member

@yurishkuro I can take this up.

@yurishkuro
Copy link
Member Author

@FlamingSaint sounds good

@shinigami-777
Copy link

hi @yurishkuro
There seems to be 2 solutions to this issue

  1. To modify the SPM e2e test to check for metrics under the new namespace.
  2. Use the Legacy metric names via the feature flag connector.spanmetrics.legacyLatencyMetricNames .
    The latter seems easy to implement but the first one seems like a more future-proof solution.

@yurishkuro
Copy link
Member Author

We'd need to do both, for backwards compatibility for people running older versions of OTEL collector

@mahadzaryab1
Copy link
Contributor

@yurishkuro i've tried out an approach to fix this - would you be able to review #6007?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
4 participants