Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Add Meter Provider To Telemetry Settings #6127

Closed
2 tasks
mahadzaryab1 opened this issue Oct 26, 2024 · 5 comments · Fixed by #6173 · May be fixed by #6132
Closed
2 tasks

[jaeger-v2] Add Meter Provider To Telemetry Settings #6127

mahadzaryab1 opened this issue Oct 26, 2024 · 5 comments · Fixed by #6173 · May be fixed by #6132
Labels
area/otel enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement v2

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Oct 26, 2024 •
edited
Loading

Requirement

We're currently using no-op meter providers in the code instead of propagating the provider from OTEL. To change this, we need to do the following:
@mahadzaryab1 mahadzaryab1 added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Oct 26, 2024
@mahadzaryab1 mahadzaryab1 mentioned this issue Oct 26, 2024
Merged
4 tasks
@Garvit-77 Garvit-77 mentioned this issue Oct 27, 2024
Open
4 tasks
@akstron
Copy link
Contributor

akstron commented Oct 29, 2024 •
edited
Loading

Hi @mahadzaryab1 we should be adding LeveledMeterProvider instead of MeterProvider right? as I see MeterProvider is deprecated.

@mahadzaryab1
Copy link
Collaborator Author

@akstron yes that’s correct!

@shinigami-777 shinigami-777 mentioned this issue Oct 31, 2024
Closed
4 tasks
@chahatsagarmain chahatsagarmain mentioned this issue Nov 7, 2024
Merged
4 tasks
@yurishkuro
Copy link
Member

Still see two more places in non-test code

$ rg noopmetric.NewMeterProvider
cmd/collector/app/handler/otlp_receiver.go
77:				return noopmetric.NewMeterProvider()
79:			MeterProvider: noopmetric.NewMeterProvider(),

cmd/collector/app/handler/zipkin_receiver.go
71:				return noopmetric.NewMeterProvider()
73:			MeterProvider: noopmetric.NewMeterProvider(),

@yurishkuro yurishkuro reopened this Nov 17, 2024
@mahadzaryab1
Copy link
Collaborator Author

@yurishkuro Those are in the context of v1 - can we do anything there?

@yurishkuro
Copy link
Member

Fair enough, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/otel enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement v2
Projects
Jaeger V2
Status: Done
Milestone
No milestone
3 participants
@yurishkuro @mahadzaryab1 @akstron