[WIP] Added the field of EnableCertReloadInterval: true everywhere it is used and in the function #6525
Conversation
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
|
@yurishkuro Some tests are failing because of the changes that are made. Most probably it is because the tests defined are not expecting reload-interval to be true. So to solve that, I think the way ahead is to make changes in the tests that were failing |
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
ADI-ROXX
force-pushed
the
reloadInterval
branch
from
1799cdf to
99809eb
Compare
|
@yurishkuro I have removed the EnableCertReloadInterval from everywhere. Can you check now. Some test cases are failing though since they are made for EnableCertReloadInterval=false. |
| @@ -131,13 +131,11 @@ func TestServerCertReloadInterval(t *testing.T) { | |||
| { | |||
| config: ServerFlagsConfig{ | |||
| Prefix: "enabled", | |||
| EnableCertReloadInterval: true, | |||
There was a problem hiding this comment.
I don't think we need this test anymore. We can just move the parsing of this flag to TestServerFlags
There was a problem hiding this comment.
So shall I remove this test completely?
There was a problem hiding this comment.
@ADI-ROXX Yeah - I think we can remove this test but we don't want to lose coverage of this flag. So we can add this flag as part of the test setup in TestServerFlags.
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
ADI-ROXX
force-pushed
the
reloadInterval
branch
from
95aa6bc to
5edf8f0
Compare
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
What is this file doing here?
There was a problem hiding this comment.
It is removed in the newer commit.
Which problem is this PR solving?
reload-intervaloption for TLS config #6521Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test