Add standard tags for internal warnings and span format #6524
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
ADI-ROXX
force-pushed
the
standardNames
branch
from
ed98b7d to
fe2315a
Compare
|
Please read contributing.md for how pr titles should be written. |
ADI-ROXX
changed the title
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
yurishkuro
reviewed
Jan 11, 2025
yurishkuro
reviewed
Jan 11, 2025
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
yurishkuro
approved these changes
Jan 11, 2025
yurishkuro
changed the title
yurishkuro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6524 +/- ##
==========================================
- Coverage 96.29% 96.25% -0.04%
==========================================
Files 372 372
Lines 21278 21278
==========================================
- Hits 20489 20481 -8
- Misses 603 609 +6
- Partials 186 188 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yurishkuro Can you give some ideas how to resolve the lint issues. I am not able to understand why they're arising. |
|
need to run |
Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
auto-merge was automatically disabled
January 11, 2025 18:28
Head branch was pushed to by a user without write access
ADI-ROXX
force-pushed
the
standardNames
branch
from
7ef908d to
025fb40
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make test