Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] add gRPC integration e2e test mode #5322

Merged
merged 31 commits into from
Apr 9, 2024
Merged

[jaeger-v2] add gRPC integration e2e test mode #5322

merged 31 commits into from
Apr 9, 2024

Commits on Apr 3, 2024

  1. Add gRPC integration e2e test mode 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    32b0678 View commit details
    Browse the repository at this point in the history

  2. Refactor changed integration functions 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    631f030 View commit details
    Browse the repository at this point in the history

  3. Fix should have grpc_test empty refresh function 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7f2e18e View commit details
    Browse the repository at this point in the history

  4. Add explanations to the e2e storage integration 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5ffd7dd View commit details
    Browse the repository at this point in the history

  5. Refactor hardcoded config file into a struct field 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ad61084 View commit details
    Browse the repository at this point in the history

  6. Fix CodeQL on SpanReader.FindTraces query.NumTraces cast 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    562c85b View commit details
    Browse the repository at this point in the history

  7. Refactor all initialization and clean up function as a test component 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3558e92 View commit details
    Browse the repository at this point in the history

  8. Refactor SpanWriter and SpanReader into separate files 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8ece354 View commit details
    Browse the repository at this point in the history

  9. Refactor RunSpanStoreTests and invoke from RunAll 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1127445 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Refactor extract grpc server into a single file 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b00b2d2 View commit details
    Browse the repository at this point in the history

  2. Refactor replace testbed test with new test and change README 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    53226e2 View commit details
    Browse the repository at this point in the history

  3. Refactor by changing in_process_collector to built binary 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6a8955a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Refactor spanWriter and spanReader to implement io.Closer 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    dbb4107 View commit details
    Browse the repository at this point in the history

  2. Close grpc server at the end of the test 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5e1e093 View commit details
    Browse the repository at this point in the history

  3. Add goleak check 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d6c1fbb View commit details
    Browse the repository at this point in the history

  4. Add error checking when shutting down grpc server 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0beaaca View commit details
    Browse the repository at this point in the history

  5. Make GRPCServer.Start idempotent by closing it if already running 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e1aba5a View commit details
    Browse the repository at this point in the history

  6. Make GRPCServer.Close idempotent by checking if already closed 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2dddea9 View commit details
    Browse the repository at this point in the history

  7. Chore fix span_writer and span_reader import format 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1ae55b2 View commit details
    Browse the repository at this point in the history

  8. Fix the initialize() called twice 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0f2ceb4 View commit details
    Browse the repository at this point in the history

  9. Move cmd.Process.Kill() to inside t.CleanUp 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    992542a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into integration-e2e-test-mode

    @james-ryans
    james-ryans committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5dc1b34 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Avoid using channel in GRPCServer 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    4fb4fff View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Refactor GRPCServer to reuse remote-storage server 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    f2cea9f View commit details
    Browse the repository at this point in the history

  2. Add comment to integration.go to clarify the usage 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    9b5b147 View commit details
    Browse the repository at this point in the history

  3. Refactor spanWriter and spanReader to start on creation 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    18876bd View commit details
    Browse the repository at this point in the history

  4. Fix ci-grpc v1 should define env SPAN_STORAGE_TYPE=memory 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    ca75924 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Temporarily skip testing trace binary type tags 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2955865 View commit details
    Browse the repository at this point in the history

  2. Delete unused spanReader Start func 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    779dff8 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Refactor remote_memory_storage to use *testing.T 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5610e5c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into integration-e2e-test-mode

    @yurishkuro
    yurishkuro committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    d88a6a5 View commit details
    Browse the repository at this point in the history