Replace grpc.Dial function that is going to be deprecated in grpc-go@v1.64 #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5336 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 343 343
Lines 16779 16780 +1
=======================================
+ Hits 15971 15972 +1
+ Misses 609 608 -1
- Partials 199 200 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
james-ryans
reviewed
Apr 7, 2024
yurishkuro
reviewed
Apr 8, 2024
|
Honestly, I have no idea at the moment. But looking at the CI message, it looks like something is wrong with the connection. https://github.com/jaegertracing/jaeger/actions/runs/8602860896/job/23573382151?pr=5336#step:7:81 My guess might be |
|
don't look at the last error message. I see that these tests timeout (the first error in the logs): |
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
tico88612
changed the title
google.golang.org/grpc to 1.63.0grpc-go@v1.64 & Refactor configmanager business logic
yurishkuro
changed the title
grpc-go@v1.64 & Refactor configmanager business logic
4 tasks
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this pull request
May 3, 2024
…v1.64 (jaegertracing#5336) ## Which problem is this PR solving? - Related jaegertracing#5330 ## Description of the changes - Partial replace deprecated function in `grpc-go@v1.64` - `grpc.Dial` => `grpc.NewClient` - `grpc.DialContext` => `grpc.NewClient` - FYI: jaegertracing#5330 (comment) - Refactor configmanager GetSamplingStrategy business logic - Fixed related test ## How was this change tested? - make lint - make test - Try & Error ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
grpc-go@v1.64grpc.Dial=>grpc.NewClientgrpc.DialContext=>grpc.NewClientHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test