Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Define an internal interface of storage v2 spanstore #5399

Merged
merged 18 commits into from
May 1, 2024
Merged

[jaeger-v2] Define an internal interface of storage v2 spanstore #5399

merged 18 commits into from
May 1, 2024

Commits on Apr 29, 2024

  1. add initial storage_v2/storage.proto API design 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b10a1ee View commit details
    Browse the repository at this point in the history

  2. move storage_v2 proto to storage_v2/proto/storage.proto 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5ad4862 View commit details
    Browse the repository at this point in the history

  3. construct the storage_v2 spanstore interface structure 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1905b67 View commit details
    Browse the repository at this point in the history

  4. Remove Close API from TraceWriter service 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5b59349 View commit details
    Browse the repository at this point in the history

  5. Add empty test to storage_v2/spanstore/ 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    36c235a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'main' into v2-storage-api

    @james-ryans
    james-ryans authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    61eba67 View commit details
    Browse the repository at this point in the history

  2. Clarify WriteTraces func description 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    663324d View commit details
    Browse the repository at this point in the history

  3. Use OTLP trace instead of Jaeger model 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    40467b0 View commit details
    Browse the repository at this point in the history

  4. Define trace not found error in spanstore pkg 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ee73249 View commit details
    Browse the repository at this point in the history

  5. Fix Reader.FindTraces description typo 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    929288e View commit details
    Browse the repository at this point in the history

  6. Remove proto file from this PR 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    27451ec View commit details
    Browse the repository at this point in the history

  7. Refactored from make fmt 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c851fb2 View commit details
    Browse the repository at this point in the history

  8. Fix GetTrace func should return only one ptrace.Traces 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    67bd83b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Change WriteTraces to accept pointer of traces 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed May 1, 2024
    Configuration menu
    Copy the full SHA
    04459ae View commit details
    Browse the repository at this point in the history

  2. Add lifecycle methods to storage_v2.Factory 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bc09999 View commit details
    Browse the repository at this point in the history

  3. Add empty test to storage_v2 pkg 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed May 1, 2024
    Configuration menu
    Copy the full SHA
    08fb5d7 View commit details
    Browse the repository at this point in the history

  4. Rename storage_v2.Factory to FactoryBase 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c6b2e27 View commit details
    Browse the repository at this point in the history

  5. Change spanstore Reader & Writer func back to accepts struct 

    Signed-off-by: James Ryans <james.ryans2012@gmail.com>
    @james-ryans
    james-ryans committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6cbd5d8 View commit details
    Browse the repository at this point in the history