Enable SPM in Jaeger v2

[FlamingSaint]

Which problem is this PR solving?

• This PR is a part of the issue [jaeger v2] Service Performance Monitoring #5632

Description of the changes

• Added a new docker-compose file
• Added the configuration file which will be used for enabling SPM in v2

How was this change tested?

• Run make dev-v2 inside docker-compose/monitor

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

Attention: Patch coverage is 97.61905% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.65%. Comparing base (74ee5d6) to head (d641e36).

Files	Patch %	Lines
...eger/internal/extension/jaegerstorage/extension.go	95.83%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5681      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.02%     
==========================================
  Files         341      342       +1     
  Lines       16451    16515      +64     
==========================================
+ Hits        15902    15962      +60     
- Misses        361      363       +2     
- Partials      188      190       +2     

Flag	Coverage Δ
badger_v1	8.05% <ø> (ø)
badger_v2	1.81% <0.00%> (-0.09%)	⬇️
cassandra-3.x-v1	16.61% <ø> (ø)
cassandra-3.x-v2	1.74% <0.00%> (-0.09%)	⬇️
cassandra-4.x-v1	16.61% <ø> (ø)
cassandra-4.x-v2	1.74% <0.00%> (-0.09%)	⬇️
elasticsearch-6.x-v1	18.78% <ø> (ø)
elasticsearch-7.x-v1	18.83% <ø> (ø)
elasticsearch-8.x-v1	19.02% <ø> (ø)
elasticsearch-8.x-v2	1.80% <0.00%> (-0.10%)	⬇️
grpc_v1	9.52% <ø> (ø)
grpc_v2	7.14% <0.00%> (-0.34%)	⬇️
kafka	9.74% <ø> (ø)
memory_v2	1.80% <0.00%> (-0.10%)	⬇️
opensearch-1.x-v1	18.89% <ø> (ø)
opensearch-2.x-v1	18.88% <ø> (ø)
opensearch-2.x-v2	1.80% <0.00%> (-0.09%)	⬇️
unittests	95.07% <97.61%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

I strongly advice including integration test in this PR, since we already have it for v1. This would be the best proof that the setup works.

[FlamingSaint]

I strongly advice including integration test in this PR, since we already have it for v1. This would be the best proof that the setup works.

Okay. I will start working on adding the e2e test for v2.

[yurishkuro]

overall lgtm, but CI for v2 failed. Please test it locally first, it's fairly quick.

  time="2024-06-28T00:59:22Z" level=warning msg="/home/runner/work/jaeger/jaeger/docker-compose/monitor/docker-compose-v2.yml: `version` is obsolete"
  jaeger-1  | 2024/06/28 00:54:31 application version: git-commit=250261fca3c21d70178ee896353c4c50e971c725, git-version=v1.58.0, build-date=2024-06-28T00:52:08Z
  jaeger-1  | Error: failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:
  jaeger-1  | 
  jaeger-1  | * error decoding 'exporters': unknown type: "prometheus" for id: "prometheus" (valid values: [otlphttp jaeger_storage_exporter kafka debug otlp])
  jaeger-1  | 2024/06/28 00:54:31 failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:
  jaeger-1  | 
  jaeger-1  | * error decoding 'exporters': unknown type: "prometheus" for id: "prometheus" (valid values: [otlphttp jaeger_storage_exporter kafka debug otlp])

[yurishkuro]

You are missing the concept of "metrics storage", similar to span storage. It can be defined as part of query extension (as it's the only dependency), and you need to change the extension code to actually create and pass that storage to QueryService.

[yurishkuro]

Can we bump the code coverage for PR to be above 95%?

[yurishkuro]

🎉