Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local images for ES integration tests #5715

Closed
wants to merge 3 commits into from

Conversation

LogicalGuy77
Copy link

Which problem is this PR solving?

Description of the changes

  • Added a new function build_local_images() that builds the local images for the index cleaner and rollover containers.
  • The function sets environment variables JAEGER_ES_INDEX_CLEANER_IMAGE and JAEGER_ES_ROLLOVER_IMAGE with the locally built image names.
  • Modified the indexCleanerImage and rolloverImage variables to use the getEnvOrDefault function. This allows them to use the environment variables set by the es-integration-test.sh script if they exist, or fall back to the default values if they don't.

How was this change tested?

Checklist

Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
@LogicalGuy77 LogicalGuy77 requested a review from a team as a code owner July 7, 2024 14:48
@dosubot dosubot bot added area/storage changelog:test Change that's adding missing tests or correcting existing tests storage/elasticsearch labels Jul 7, 2024
@@ -18,6 +18,20 @@ check_arg() {
fi
}

# Build local images for index cleaner and rollover
build_local_images() {
local j_version=$1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was an unused variable. I've removed it now.

LogicalGuy77 and others added 2 commits July 7, 2024 23:21
Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
@yurishkuro
Copy link
Member

This has been solved in #5714

@yurishkuro yurishkuro closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:test Change that's adding missing tests or correcting existing tests storage/elasticsearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use current code, not published images, in ES integration tests
2 participants