-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a docker-compose for hotrod e2e test #5740
Conversation
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5740 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 341 341
Lines 16451 16451
=======================================
Hits 15902 15902
Misses 361 361
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I suggest you explain your plan, doesn't seem it's going in the right direction. We already have all the pieces you included in this PR |
@yurishkuro my plan is to build a local hotrod image(localhost:5000/jaegertracing/example-hotrod:${GITHUB_SHA:-latest}) and test it using docker-compose(that way we won't have any error for port 4318) then we will hit the frontend end point and get the hotrod logs and get the tracesID from there |
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have UI submodule affected in this PR, please remove.
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, a couple open questions
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
Thanks! |
|
||
bash scripts/build-upload-a-docker-image.sh -c example-hotrod -d examples/hotrod -p "${platforms}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should not have been deleted. It needs to run as the last step of the script.
## Which problem is this PR solving? - jaegertracing#5735 ## Description of the changes - added docker-compose file to test hotrod so that is can connect to jaeger ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: mehul gautam <mehulsharma4786@gamil.com> Co-authored-by: mehul gautam <mehulsharma4786@gamil.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test