Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmd/jaeger/internal/integration/receivers/storagereceiver/ #5749

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Remove cmd/jaeger/internal/integration/receivers/storagereceiver/ #5749

merged 1 commit into from
Jul 17, 2024
+0 −616

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Dead code, we ended up not using this for v2 e2e tests

Description of the changes

  • Remove whole package

@yurishkuro
Remove cmd/jaeger/internal/integration/receivers/storagereceiver/
a845c59 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Jul 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (8d2aab6) to head (a845c59).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5749      +/-   ##
==========================================
+ Coverage   96.69%   96.70%   +0.01%     
==========================================
  Files         341      341              
  Lines       16444    16444              
==========================================
+ Hits        15900    15902       +2     
+ Misses        355      354       -1     
+ Partials      189      188       -1
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.80% <ø> (ø)
elasticsearch-7.x-v1 18.86% <ø> (ø)
elasticsearch-8.x-v1 19.05% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.89% <ø> (-0.02%) ⬇️
grpc_v1 9.53% <ø> (ø)
grpc_v2 7.48% <ø> (ø)
kafka 9.75% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.91% <ø> (ø)
opensearch-2.x-v2 1.89% <ø> (-0.02%) ⬇️
unittests 95.12% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review July 16, 2024 01:27
@yurishkuro yurishkuro requested a review from a team as a code owner July 16, 2024 01:27
@yurishkuro
Copy link
Member Author

@james-ryans stamp?

@yurishkuro yurishkuro merged commit 7b89144 into jaegertracing:main Jul 17, 2024
44 checks passed
@yurishkuro yurishkuro deleted the remove-receivers/storagereceiver branch July 17, 2024 01:32
FlamingSaint pushed a commit to FlamingSaint/jaeger that referenced this pull request Jul 20, 2024
@yurishkuro @FlamingSaint
Remove cmd/jaeger/internal/integration/receivers/storagereceiver/ (ja…
a5d899a 
…egertracing#5749)

- Dead code, we ended up not using this for v2 e2e tests

- Remove whole package

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-ryans james-ryans james-ryans approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @james-ryans