[v2] Add e2e test with memory store #5751
Merged
+107
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
v2
changelog:ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5751 +/- ##
==========================================
- Coverage 96.69% 96.66% -0.03%
==========================================
Files 341 341
Lines 16444 16451 +7
==========================================
+ Hits 15900 15902 +2
- Misses 355 361 +6
+ Partials 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FlamingSaint
pushed a commit
to FlamingSaint/jaeger
that referenced
this pull request
Jul 20, 2024
## Which problem is this PR solving? - Even though we were using memory storage in v2-e2e-grpc test, we never had an e2e that would validate `cmd/jaeger/config.yaml` config, which uses memory storage in-process ## Description of the changes - Add the new test workflow an e2e test - Rename other test files for more readable file names / test names ## How was this change tested? - build cmd/jaeger binary - `$ STORAGE=memory go test ./cmd/jaeger/internal/integration` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
cmd/jaeger/config.yamlconfig, which uses memory storage in-processDescription of the changes
How was this change tested?
$ STORAGE=memory go test ./cmd/jaeger/internal/integration