Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip building HotROD for all platforms for pull requests #5763

Closed

Conversation

Charan-Sharan
Copy link

@Charan-Sharan Charan-Sharan commented Jul 18, 2024

Which problem is this PR solving?

Description of the changes

  • To Skip building HotROD for all platforms for pull requests, We are adding BUILD_FLAGS=-l -p linux/amd64 in
    .github/workflows/ci-hotrod.yml while executing scripts/hotrod-integration-test.sh.
    Where,
    • -l for local build only (no pushing to public registry)
    • '-p' to only build for specified platforms and not all.

How was this change tested?

  • I only tested how the flags are being passed to the script file.
  • GitHub Actions related stuff is yet to be tested.

Checklist

Signed-off-by: Charan-Sharan <charansharan2004@gmail.com>
@Charan-Sharan Charan-Sharan requested a review from a team as a code owner July 18, 2024 21:21
@yurishkuro
Copy link
Member

@Charan-Sharan thanks for contributing. We went with an earlier PR #5765

@yurishkuro yurishkuro closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants