Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog with breaking change #5770

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

yurishkuro
Copy link
Member

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner July 21, 2024 21:35
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (b2aded6) to head (382d711).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5770      +/-   ##
==========================================
+ Coverage   96.65%   96.66%   +0.01%     
==========================================
  Files         341      341              
  Lines       16451    16451              
==========================================
+ Hits        15900    15902       +2     
+ Misses        362      361       -1     
+ Partials      189      188       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.03% <ø> (ø)
elasticsearch-8.x-v2 1.88% <ø> (ø)
grpc_v1 9.51% <ø> (-0.02%) ⬇️
grpc_v2 7.47% <ø> (ø)
kafka 9.74% <ø> (ø)
memory_v2 1.88% <ø> (ø)
opensearch-1.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.89% <ø> (+0.01%) ⬆️
opensearch-2.x-v2 1.90% <ø> (+0.01%) ⬆️
unittests 95.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro merged commit 6bd7aea into jaegertracing:main Jul 22, 2024
43 of 44 checks passed
@yurishkuro yurishkuro deleted the changelog-5737 branch July 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants