Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Consolidate Options And NamespaceConfig For Badger Storage #5937

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Sep 5, 2024

Which problem is this PR solving?

Description of the changes

  • Removed the Options struct and renamed NamespaceConfig to Namespace for Badger Storage
  • Moved v2-related configuration items to config.go while leaving v1 cli flags in options.go

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (8d8719a) to head (0ad11eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5937      +/-   ##
==========================================
- Coverage   96.82%   96.81%   -0.02%     
==========================================
  Files         344      345       +1     
  Lines       16537    16528       -9     
==========================================
- Hits        16012    16001      -11     
- Misses        339      340       +1     
- Partials      186      187       +1     
Flag Coverage Δ
badger_v1 8.03% <44.44%> (-0.06%) ⬇️
badger_v2 1.82% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v1 16.62% <0.00%> (+0.01%) ⬆️
cassandra-3.x-v2 1.75% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 16.62% <0.00%> (+0.01%) ⬆️
cassandra-4.x-v2 1.75% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.79% <0.00%> (+0.02%) ⬆️
elasticsearch-7.x-v1 18.85% <0.00%> (+0.02%) ⬆️
elasticsearch-8.x-v1 19.03% <0.00%> (+0.02%) ⬆️
elasticsearch-8.x-v2 1.81% <0.00%> (?)
grpc_v1 9.49% <0.00%> (+0.01%) ⬆️
grpc_v2 7.16% <0.00%> (+<0.01%) ⬆️
kafka-v1 9.74% <0.00%> (+0.01%) ⬆️
kafka-v2 1.82% <0.00%> (+<0.01%) ⬆️
memory_v2 1.82% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 18.90% <0.00%> (+0.02%) ⬆️
opensearch-2.x-v1 18.89% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v2 1.81% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.46% <0.00%> (+<0.01%) ⬆️
unittests 95.29% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review September 5, 2024 02:35
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner September 5, 2024 02:35
@dosubot dosubot bot added area/storage storage/badger Issues related to badger storage v2 labels Sep 5, 2024
plugin/storage/badger/config.go Outdated Show resolved Hide resolved
plugin/storage/badger/config.go Outdated Show resolved Hide resolved
plugin/storage/badger/factory.go Outdated Show resolved Hide resolved
mahadzaryab1 and others added 4 commits September 4, 2024 23:08
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@yurishkuro yurishkuro enabled auto-merge (squash) September 5, 2024 03:20
@yurishkuro yurishkuro merged commit 978ecbf into jaegertracing:main Sep 5, 2024
49 of 50 checks passed
@mahadzaryab1 mahadzaryab1 deleted the consolidate-badger branch September 28, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants