Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The 'tagType' in ES jaeger-span mapping tags.properties should be 'type' #5980

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

chinaran
Copy link
Contributor

Which problem is this PR solving?

Resolves #5967

Checklist

…e 'type'

Signed-off-by: 王然 <ranwang@alauda.io>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (7787010) to head (9ef579d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5980      +/-   ##
==========================================
- Coverage   96.82%   96.81%   -0.02%     
==========================================
  Files         345      345              
  Lines       16523    16523              
==========================================
- Hits        15998    15996       -2     
- Misses        339      340       +1     
- Partials      186      187       +1     
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.83% <ø> (ø)
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (-0.02%) ⬇️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.15% <ø> (+0.01%) ⬆️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit af00f3a into jaegertracing:main Sep 13, 2024
49 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Is ‘tagType’ in ES jaeger-span mapping correct? Should it be ‘type’?
2 participants