Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable publishing of versioned jaeger-v2 artifacts #5984

Merged
merged 14 commits into from
Sep 14, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 14, 2024

Which problem is this PR solving?

Description of the changes

  • simplify all-in-one publishing by minimizing number of parameters passed from workflow (v1/v2 only instead of binary name and healthcheck flag - those are now set inside the script)
  • implement overwrite -o flag in docker scripts to avoid accidental overriding of numbered releases
  • simplify flags management in docker scripts via FLAGS array instead of individual variables
  • fix base image building to respect selected platforms (by default it was building all)
  • allow scripts/compute-version.sh to accept semver with -rcN suffix

How was this change tested?

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 14, 2024 18:02
@dosubot dosubot bot added the docker Pull requests that update Docker code label Sep 14, 2024
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (7d6ebaa) to head (90695dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5984      +/-   ##
==========================================
- Coverage   96.82%   96.81%   -0.02%     
==========================================
  Files         345      345              
  Lines       16523    16523              
==========================================
- Hits        15998    15996       -2     
- Misses        339      340       +1     
- Partials      186      187       +1     
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (+0.01%) ⬆️
elasticsearch-7.x-v1 18.83% <ø> (ø)
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.81% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.88% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Release v2 cleanup 3 Enable publishing of versioned jaeger-v2 artifacts Sep 14, 2024
@yurishkuro yurishkuro merged commit 4640518 into main Sep 14, 2024
49 checks passed
@yurishkuro yurishkuro deleted the release-v2-cleanup-3 branch September 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant