Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Align Kafka Storage Config With OTEL #6003

Closed

Conversation

mahadzaryab1
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (dd73e8a) to head (759bb42).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6003   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         348      348           
  Lines       16559    16565    +6     
=======================================
+ Hits        16026    16033    +7     
+ Misses        344      343    -1     
  Partials      189      189           
Flag Coverage Δ
badger_v1 8.02% <0.00%> (-0.01%) ⬇️
badger_v2 1.82% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.60% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2 1.75% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1 16.60% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2 1.75% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.76% <0.00%> (?)
elasticsearch-7.x-v1 18.82% <0.00%> (?)
elasticsearch-8.x-v1 19.02% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.81% <0.00%> (-0.02%) ⬇️
grpc_v1 9.50% <0.00%> (-0.02%) ⬇️
grpc_v2 7.15% <0.00%> (-0.01%) ⬇️
kafka-v1 9.99% <76.19%> (+0.24%) ⬆️
kafka-v2 1.82% <0.00%> (-0.01%) ⬇️
memory_v2 1.82% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.87% <0.00%> (-0.02%) ⬇️
opensearch-2.x-v1 18.87% <0.00%> (-0.03%) ⬇️
opensearch-2.x-v2 1.81% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.46% <0.00%> (-0.01%) ⬇️
unittests 95.27% <95.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mahadzaryab1 and others added 5 commits September 19, 2024 20:15
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@yurishkuro
Copy link
Member

in v2 we are using upstream Kafka exporter and receiver, I don't think there's anything that we need to fix.

@mahadzaryab1
Copy link
Contributor Author

in v2 we are using upstream Kafka exporter and receiver, I don't think there's anything that we need to fix.

Ah I see. I didn't realize that these configs are only used by v1. Is there anything that needs to be done for Kafka as there is a checkbox for it on #5229? If not, I can close out this PR and the corresponding issue.

@yurishkuro
Copy link
Member

no, nothing to do for Kafka in v2

@mahadzaryab1
Copy link
Contributor Author

Closed as per discussion above

@mahadzaryab1 mahadzaryab1 deleted the kafka-storage-v2 branch September 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jaeger-v2] Align Kafka Config With OTEL
2 participants