-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Align Kafka Storage Config With OTEL #6003
Conversation
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6003 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 348 348
Lines 16559 16565 +6
=======================================
+ Hits 16026 16033 +7
+ Misses 344 343 -1
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
in v2 we are using upstream Kafka exporter and receiver, I don't think there's anything that we need to fix. |
Ah I see. I didn't realize that these configs are only used by v1. Is there anything that needs to be done for Kafka as there is a checkbox for it on #5229? If not, I can close out this PR and the corresponding issue. |
no, nothing to do for Kafka in v2 |
Closed as per discussion above |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test