Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Label Validation in SPM Integration Test #6142

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

akstron
Copy link
Contributor

@akstron akstron commented Oct 31, 2024

Which problem is this PR solving?

Description of the changes

  • The changes include requesting metric with groupByOperation to get labels along with operation. This is then compared with the expected label set = "operation service_name"

How was this change tested?

  • jaeger/scripts/spm-integration-test.sh

Checklist

Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@akstron akstron requested a review from a team as a code owner October 31, 2024 09:00
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (b644701) to head (fa435e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6142   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20107    20107           
=======================================
  Hits        19398    19398           
  Misses        524      524           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (?)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.53% <ø> (ø)
elasticsearch-7.x-v1 18.60% <ø> (ø)
elasticsearch-8.x-v1 18.78% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <ø> (ø)
grpc_v1 9.50% <ø> (+<0.01%) ⬆️
grpc_v2 7.01% <ø> (ø)
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.67% <ø> (?)
opensearch-1.x-v1 18.65% <ø> (ø)
opensearch-2.x-v1 18.65% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (-0.02%) ⬇️
tailsampling-processor 0.47% <ø> (?)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added changelog:ci Change related to continuous integration / testing changelog:test Change that's adding missing tests or correcting existing tests and removed changelog:ci Change related to continuous integration / testing labels Nov 1, 2024
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@yurishkuro yurishkuro enabled auto-merge (squash) November 2, 2024 03:35
@yurishkuro yurishkuro enabled auto-merge (squash) November 2, 2024 03:36
@yurishkuro yurishkuro merged commit 390d728 into jaegertracing:main Nov 2, 2024
48 of 50 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants