Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perses to monitor example #6149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pavolloffay
Copy link
Member

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from a team as a code owner November 1, 2024 10:53
@dosubot dosubot bot added the docker Pull requests that update Docker code label Nov 1, 2024
@pavolloffay pavolloffay added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (43d2367) to head (a819d25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6149   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         353      353           
  Lines       20107    20107           
=======================================
  Hits        19398    19398           
  Misses        524      524           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.53% <ø> (ø)
elasticsearch-7.x-v1 18.61% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.78% <ø> (ø)
elasticsearch-8.x-v2 1.67% <ø> (-0.02%) ⬇️
grpc_v1 9.50% <ø> (ø)
grpc_v2 7.01% <ø> (ø)
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.68% <ø> (ø)
opensearch-1.x-v1 18.65% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.65% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@yurishkuro
Copy link
Member

What's the objective?

@jkowall
Copy link
Contributor

jkowall commented Nov 1, 2024

@yurishkuro we can use Grafana and Perses to demo the metrics now. Perses is another visualization tool for time series which is part of CNCF. As you are aware Grafana's license could change at some point, so this is nice to have for demo/testing purposes.

@yurishkuro
Copy link
Member

I think we should remove grafana as well. The point of the example is to demonstrate SPM capability, not the metrics generation. For debugging purposes Prometheus has a basic UI.

@jkowall
Copy link
Contributor

jkowall commented Nov 1, 2024

While I agree with you, we have to think about the user.... Most Jaeger users are also using Grafana which is open source today, so I think it's nice to demo. Grafana can also visualize the Jaeger data which is nice to show.

@yurishkuro
Copy link
Member

We also need to think about Jaeger the project. Grafana was added when it only had metrics. Now it's a direct competitor with Jaeger UI.

@jkowall
Copy link
Contributor

jkowall commented Nov 2, 2024

When I show both in a demo, I explain how Grafana doesn't have the search or other capabilities Jaeger has, however if you want to visualize a trace, they are both capable, same with OpenSearch. The fact is that pretty much every Prometheus user is using Grafana, hence they would likely be using it with Jaeger. These are the facts until Perses gains popularity over the next several years, I hope.

@jkowall jkowall mentioned this pull request Nov 4, 2024
2 tasks
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants