Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(spm) Cleanup grafana #6158

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Nov 4, 2024

Which problem is this PR solving?

Part of #6149 and #6148

Description of the changes

Remove leftover files and update readme

Checklist

…r setup

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall requested a review from a team as a code owner November 4, 2024 07:17
@dosubot dosubot bot added the docker Pull requests that update Docker code label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (772d84c) to head (674c356).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6158   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20126    20126           
=======================================
  Hits        19417    19417           
  Misses        524      524           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v2 1.67% <ø> (ø)
grpc_v1 9.47% <ø> (-0.01%) ⬇️
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro changed the title Cleanup grafana and add mention of perses in README for monitor Cleanup grafana for monitor Nov 4, 2024
@yurishkuro yurishkuro changed the title Cleanup grafana for monitor (spm) Cleanup grafana Nov 4, 2024
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Nov 4, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perses is not merged

@yurishkuro yurishkuro enabled auto-merge (squash) November 4, 2024 14:51
@yurishkuro yurishkuro merged commit 1378e91 into jaegertracing:main Nov 4, 2024
50 of 51 checks passed
@jkowall jkowall deleted the grafana-cleanup branch November 4, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants