Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use testify instead of t.Fatal #6162

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 4, 2024

Description of the changes

  • Replaces t.Fatal calls with "github.com/stretchr/testify/require" use

How was this change tested?

  • CI

Checklist

@mmorel-35 mmorel-35 marked this pull request as ready for review November 4, 2024 22:24
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 4, 2024 22:24
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (c65757f) to head (78c54fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6162      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files         354      354              
  Lines       20126    20126              
==========================================
+ Hits        19417    19420       +3     
+ Misses        524      522       -2     
+ Partials      185      184       -1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/metrics/prometheus/factory_test.go Outdated Show resolved Hide resolved
cmd/agent/app/agent_test.go Outdated Show resolved Hide resolved
plugin/storage/integration/elasticsearch_test.go Outdated Show resolved Hide resolved
mmorel-35 and others added 3 commits November 4, 2024 23:49
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
cmd/agent/app/agent_test.go Outdated Show resolved Hide resolved
plugin/storage/integration/elasticsearch_test.go Outdated Show resolved Hide resolved
cmd/agent/app/agent_test.go Outdated Show resolved Hide resolved
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Nov 4, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) November 4, 2024 23:06
@yurishkuro yurishkuro merged commit 0a24f6d into jaegertracing:main Nov 4, 2024
50 checks passed
@mmorel-35 mmorel-35 deleted the testifier/require-error branch November 4, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants