[CI][WIP] Scrape metrics at the end of e2e test #6330
Conversation
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6330 +/- ##
==========================================
+ Coverage 96.27% 96.29% +0.01%
==========================================
Files 372 372
Lines 21283 21278 -5
==========================================
- Hits 20491 20489 -2
+ Misses 605 603 -2
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
chahatsagarmain
changed the title
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
| if: ${{ (github.ref_name == 'main') && (steps.check-cache.outputs.cache-hit != 'true') }} | ||
| shell: bash | ||
| run: | | ||
| mv ./.metrics/${{ inputs.snapshot }} ./.metrics/cached_${{ inputs.snapshot}} |
| with: | ||
| path: ./.metrics/cached_${{ inputs.snapshot}} | ||
| key: ${{ env.v2_tag }}_${{ inputs.artifact_key }} | ||
| lookup-only: true |
There was a problem hiding this comment.
why lookup-only? Is the step going to hard fail otherwise?
There was a problem hiding this comment.
I don't understand the purpose of this step. We already have download-release-snapshot step below.
| if: ${{ (github.ref_name == 'main') && (steps.check-cache.outputs.cache-hit != 'true') }} | ||
| uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57 | ||
| with: | ||
| path: ./.metrics/cached_${{ inputs.snapshot}} |
There was a problem hiding this comment.
why do you need to refer to file name with cached_ prefix? The name is meaningless after upload, only artifact.key matters.
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
| - name: Cache scraped metrics for tagged release for longer retention | ||
| id: tagged-metrics | ||
| if: ${{ (github.ref_name == 'main') && (steps.check-cache.outputs.cache-hit != 'true') }} |
There was a problem hiding this comment.
| if: ${{ (github.ref_name == 'main') && (steps.check-cache.outputs.cache-hit != 'true') }} | |
| if: ${{ (github.ref_name == 'main') }} |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
… into e2e-metrics Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
|
@yurishkuro Looks like github actions cache does not allow overwriting cache with the same key |
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
|
|
||
| - name: Calculate diff between the snapshots | ||
| id: compare-snapshots | ||
| if: steps.download-release-snapshot.outputs.cache-hit == 'true' |
There was a problem hiding this comment.
if this runs on main there wouldn't be a file named ./.metrics/${{ inputs.snapshot }} because it would've been moved two steps above
Option (1) is not good because we'd be always comparing to a month-old snapshot, so if several PRs since then make expected changes to the metrics then the diffs will be cumulative, which is not helpful. Option (2) seems reasonable if we can do it. Isn't there some |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test