Update to syn 2 #185
Merged
Update to syn 2 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaemk Reminder :D |
|
Hey @omid, nice work. Looking at it, it mostly just seems like Only thing I've noticed is that we've now got a few calls of |
It doesn't look like they are needed
|
Thanks a lot @BaxHugh. Just merged 🙏🏼 |
|
FYI, I'm going to wait to release these changes since there's a couple more breaking changes in PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🚧 🚧
It's a breaking change!
🚧 🚧 🚧
Because syn throws an error for keywords, we have to rename
typeto something else. A general pattern is to usetyinstead oftype.