Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disk cache sync on change and sled connection config #194

Conversation

BaxHugh
Copy link
Contributor

@BaxHugh BaxHugh commented Apr 3, 2024

This PR concerns only the DiskCache

Closes #190

The main features of this PR are

This replaces #192

(the PRs in my clone are all stacked, but I don't think I can do that within this repo, so it is in one big PR to master here)

@BaxHugh
Copy link
Contributor Author

BaxHugh commented Apr 4, 2024

This will have a few small merge conflicts with the changes in #185. So happy to merge this after that PR is merged.

But if someone could have a little review @omid @jaemk, that would be fantastic as this is something I'm hoping to use very soon in my work project. (I've linked to separate smaller PRs to make diffs easier to digest).

Also, if there's any PRs in particularly that it'd be helpful for me to help with reviewing, let me know..

src/stores/disk.rs Outdated Show resolved Hide resolved
@BaxHugh BaxHugh force-pushed the feature/DiskCache-sync-on-change-and-sled-connection-config branch 3 times, most recently from 8a2585e to 7876fe7 Compare April 7, 2024 15:21
@jaemk
Copy link
Owner

jaemk commented Apr 7, 2024

@BaxHugh would you mind resolving the disk.rs conflicts for me

Added flag to io_cached macro for this too

Currently only implemented for DiskCache, not redis etc.
In initial implementation, this was only on cache_set, but this has now been made more generic to sync to disk everytime a cache value is updated, this includes refreshing and removing
…)` to `Result<(), DiskCacheError>`

- returns the result of connection.flush()
@BaxHugh BaxHugh force-pushed the feature/DiskCache-sync-on-change-and-sled-connection-config branch from 7876fe7 to 7dfd544 Compare April 8, 2024 08:28
@BaxHugh
Copy link
Contributor Author

BaxHugh commented Apr 8, 2024

@jaemk, no problem.
Done: (rebased onto master)

@jaemk jaemk merged commit fdbfd57 into jaemk:master Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disk Cache does not persist between runs
2 participants