-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disk cache sync on change and sled connection config #194
Feature/disk cache sync on change and sled connection config #194
Conversation
This will have a few small merge conflicts with the changes in #185. So happy to merge this after that PR is merged. But if someone could have a little review @omid @jaemk, that would be fantastic as this is something I'm hoping to use very soon in my work project. (I've linked to separate smaller PRs to make diffs easier to digest). Also, if there's any PRs in particularly that it'd be helpful for me to help with reviewing, let me know.. |
8a2585e
to
7876fe7
Compare
@BaxHugh would you mind resolving the disk.rs conflicts for me |
Added flag to io_cached macro for this too Currently only implemented for DiskCache, not redis etc.
In initial implementation, this was only on cache_set, but this has now been made more generic to sync to disk everytime a cache value is updated, this includes refreshing and removing
…sk_on_cache_change args
…ge-and-sled-connection-config branch
…)` to `Result<(), DiskCacheError>` - returns the result of connection.flush()
7876fe7
to
7dfd544
Compare
@jaemk, no problem. |
This PR concerns only the
DiskCache
Closes #190
The main features of this PR are
This replaces #192
(the PRs in my clone are all stacked, but I don't think I can do that within this repo, so it is in one big PR to master here)