Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Firepad/brace text editor causes route error on load #14

Open
jake-pauls opened this issue Jun 10, 2021 · 0 comments
Open

[BUG] Firepad/brace text editor causes route error on load #14

jake-pauls opened this issue Jun 10, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jake-pauls
Copy link
Owner

Describe the bug
When loading the Editor.vue component, a session ID is passed to the current browser's url in order to provide synchronous editing. In doing this, the Vue router isn't aware of this route and instead returns a 404 (that, fails to load?).

Although this doesn't break the feature, it's worth looking into.

Steps to Reproduce
Steps to reproduce this bug:

  1. Navigate to Editor.vue on the firepad-integration branch
  2. Open the developer console to see the error

Expected behavior
The Vue router recognizes that this path is meant to have a session ID and it doesn't return the 404.

2021-06-10-14:38:55-scrot

Additional Info
This could be fixed when we bring together the editor and the video call components.

@jake-pauls jake-pauls added the bug Something isn't working label Jun 10, 2021
@jake-pauls jake-pauls self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant