Fix deprecation warning on Formatting.jl package #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because * The package was deprecated and the new Format.jl package should be used instead This commit only changes one package with another and fixes the deprecation warning.
|
Thanks for this @pmc4! Great stuff—I didn't know Formatting.jl was deprecated (I wrote this a while ago). I know Scott (@ScottPJones) from the Humans of Julia Discord server, and Format.jl looks great. Just needed to do the same change in the documentation directory (there's probably a better way to do this without replicating the package dependencies in |
jakewilliami
approved these changes
Sep 8, 2024
|
No problem @jakewilliami ! I forgot about the docs, thanks for pointing that out. I'll bear that in mind for the next time. I just came across your package when solving one of the Project Euler problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing SpelledOut.jl in a new Julia environment, a deprecation warning by the Formatting.jl package is given.
As can be see in its repository, the package is deprecated and should be interchanged with the more modern Format.jl package from here.
This branch fixes that deprecation warning by changing both packages. The only imported function from
Formatting.jlwasformat. The same syntax holds for theFormat.jlso no further changes must be made. The branch passed all the tests locally.