Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tapd): Add support for litd v0.14.0-alpha #1039

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Oct 30, 2024

Description

Adds support for the upcoming litd v0.14.0-alpha release. There were some changes necessary on the Polar side to get it working correctly. This mostly focused on the new tapd AddInvoice and SendPayment RPCs which simplify the integration of creating and paying asset invoices. Polar previously used had to re-implement the code from litcli ln addinvoice/payinvoice. By switching to use these new RPCs, I was able to remove a bunch of lower level RPCs calls.

I have been testing this with the PR lightninglabs/lightning-terminal#848 which hasn't been merged yet. So I will keep this PR open until the final litd v0.14.0 version is released.

Steps to Test

First, you'll need to build the docker image using the litd PR branch:

$ cd docker/litd/
$ docker build --build-arg LITD_VERSION=update-to-lnd-18-4 -t polarlightning/litd:0.14.0-pre1 -f src.Dockerfile --no-cache .

Then in Polar:

  1. Create a new network with 4 litd nodes
  2. Mint a PUSD asset with a 1000 supply
  3. Create an 500 PUSD asset address on carol
  4. Send PUSD to that address from alice
  5. Open a 400 PUSD asset channel from alice to bob
  6. Open a 1M sats channel from bob to carol
  7. Open a 400 PUSD asset channel from carol to dave
  8. Create a 200 PUSD asset invoice on dave
  9. Pay the invoice on alice using PUSD
  10. Confirm the payment completes successfully

Screenshots

image

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4eb2908) to head (3e463c5).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1039   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       151           
  Lines         5513      5492   -21     
  Branches      1110      1110           
=========================================
- Hits          5513      5492   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelvinator07
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants