fix segments not being quoted if they contain a comma, commit db tran…

…sactions between COPY's
jamesmeneghello · Feb 11, 2015 · b9bd6c2 · b9bd6c2
1 parent 9926b72
commit b9bd6c2
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/pynab/parts.py b/pynab/parts.py
@@ -60,7 +60,7 @@ def save_all(parts):
                             s.write('"' + part[item].replace(tzinfo=None).strftime('%Y-%m-%d %H:%M:%S').replace('"',
                                                                                                                 '\\"') + '",')
                         elif item == 'xref':
-                            # leave off the tab
+                            # leave off the comma
                             s.write('"' + part[item].replace('"', '\\"') + '"')
                         else:
                             s.write('"' + str(part[item]).replace('"', '\\"') + '",')
@@ -69,6 +69,8 @@ def save_all(parts):
 
                 copy_file(engine, s, ordering, Part)
 
+                db.commit()
+
         with db_session() as db:
             existing_parts = dict(
                 ((part.hash, part) for part in
@@ -111,14 +113,16 @@ def save_all(parts):
                     for item in ordering:
                         if item == 'part_id':
                             # leave off the tab
-                            s.write(str(segment[item]))
+                            s.write('"' + str(segment[item]).replace('"', '\\"') + '"')
                         else:
-                            s.write(str(segment[item]) + ",")
+                            s.write('"' + str(segment[item]).replace('"', '\\"') + '",')
                     s.write("\n")
                 s.seek(0)
 
                 copy_file(engine, s, ordering, Segment)
 
+                db.commit()
+
         end = time.time()
 
         log.debug('parts: saved {} parts and {} segments in {:.2f}s'.format(