Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs Thinking] Consistency between InstrumentSettings and Swing after user input. #6

Open
jandejongh opened this issue Dec 29, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jandejongh
Copy link
Owner

jandejongh commented Dec 29, 2019

[AbstractInstrument] At the present time, user input on an [Swing] Instrument View typically results in an applicable "request" to the Instrument. If the request results in a change in Instrument Settings, the implementation of AbstractInstrument will report the new Instrument Settings to its listeners, and as a result the Instrument View Swing state will be updated.
However, some user interactions result in an immediate change in Swing components, and if the "request" did not result in different Instrument Settings, the component is not informed about it because AbstractInstrument only propagates changes to the Instrument Settings.
As a result, the Swing component is left in an inconsistent state.
A solution could be to inform AbstractInstrument that a specific listener wants ALL readings of the InstrumentSettings, instead of just the "deltas".

@jandejongh jandejongh added the bug Something isn't working label Dec 29, 2019
@jandejongh jandejongh self-assigned this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant