Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda recipe fixes #396

Merged
merged 2 commits into from
May 22, 2024
Merged

Conda recipe fixes #396

merged 2 commits into from
May 22, 2024

Conversation

stuarteberg
Copy link
Member

@stuarteberg stuarteberg commented May 21, 2024

  • I added make to the build requirements.
  • For now, I've removed the MACOSX_DEPLOYMENT_TARGET, since I'm had trouble using old SDKs with new versions of Xcode. This means that the mac build will be different depending on the machine we build it with. But to my knowledge, I'm the only one building the Mac binaries anyway...

This change is Reviewable

Copy link
Member

@DocSavage DocSavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stuarteberg)

@DocSavage DocSavage merged commit 2976699 into master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants