Modify string concat to text block cleanup to handle empty strings (e…

…clipse-jdt#1717) - add logic to StringConcatToTextBlockFixCore to handle the case where empty strings are appended - modify tests in CleanUpTest15 to add some empty strings to existing tests - for eclipse-jdt#1703
jannisCode · Oct 15, 2024 · c2ceaa2 · c2ceaa2
1 parent 29f2f2d
commit c2ceaa2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...on/core extension/org/eclipse/jdt/internal/corext/fix/StringConcatToTextBlockFixCore.java b/...on/core extension/org/eclipse/jdt/internal/corext/fix/StringConcatToTextBlockFixCore.java
@@ -156,7 +156,7 @@ public boolean visit(final InfixExpression visited) {
 					endPosition= getLineOffset(cUnit, lineNo + 1) == -1 ? cUnit.getLength() : getLineOffset(cUnit, lineNo + 1);
 					hasComments= hasComments || hasNLS(ASTNodes.getCommentsForRegion(cUnit, stringLiteral.getStartPosition(), endPosition - stringLiteral.getStartPosition()), cu);
 					String string= stringLiteral.getLiteralValue();
-					if (!string.isEmpty() && (fAllConcats || string.endsWith("\n") || i == extendedOperands.size() - 1)) { //$NON-NLS-1$
+					if (string.isEmpty() || fAllConcats || string.endsWith("\n") || i == extendedOperands.size() - 1) { //$NON-NLS-1$
 						continue;
 					}
 				}
@@ -315,8 +315,11 @@ public SourceRange computeSourceRange(final ASTNode nodeWithComment) {
 			expressions.forEach(new Consumer<Expression>() {
 				@Override
 				public void accept(Expression t) {
-					String value= ((StringLiteral) t).getEscapedValue();
-					parts.addAll(unescapeBlock(value.substring(1, value.length() - 1)));
+					StringLiteral literal= (StringLiteral)t;
+					if (!literal.getLiteralValue().equals("\"\"")) { //$NON-NLS-1$
+						String value= literal.getEscapedValue();
+						parts.addAll(unescapeBlock(value.substring(1, value.length() - 1)));
+					}
 				}
 			});
 

diff --git a/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest15.java b/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest15.java
@@ -117,14 +117,15 @@ public void testParameter() {
 			        Integer k = foo("" +\s
 			                  "abcdef\\n" +\s
 			                  "123456\\n" +\s
-			                  "klm");
+			                  "klm" +\s
+			                  "");
 			    }
 			    public void testAssignment() {
 			        Integer k = null;
 			        k = foo("" +\s
 			                  "abcdef\\n" +\s
 			                  "123456\\n" +\s
-			                  "klm");
+			                  "" + "klm");
 			    }
 			    public void testConcatInConstructor() {
 			        new StringBuffer("abc\\n" + "def\\n" + "ghi");