Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 - Track sales tax paid on transactions #291

Merged
merged 6 commits into from
Jan 25, 2024
Merged

1.2.0 - Track sales tax paid on transactions #291

merged 6 commits into from
Jan 25, 2024

Conversation

jantman
Copy link
Owner

@jantman jantman commented Jan 25, 2024

This is really a minor update, that adds a field to the Transaction modal to allow tracking sales tax paid.

We're pinned to an ancient sphinx version that doesn't work with 3.11;
ugprading Python is going to be a significant task, which I'll undertake later.
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (82d67e6) 50.42% compared to head (7a0d3a4) 50.46%.

Files Patch % Lines
biweeklybudget/flaskapp/views/transactions.py 0.00% 3 Missing ⚠️
...774fa3ae3_add_transaction_field_to_store_sales_.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   50.42%   50.46%   +0.03%     
==========================================
  Files          82       83       +1     
  Lines        5263     5277      +14     
  Branches      810      811       +1     
==========================================
+ Hits         2654     2663       +9     
- Misses       2556     2561       +5     
  Partials       53       53              
Flag Coverage Δ
acceptance 42.50% <64.28%> (+0.05%) ⬆️
unittests 47.20% <64.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jantman jantman merged commit 9e05911 into master Jan 25, 2024
20 of 21 checks passed
@jantman jantman deleted the sales-tax branch January 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant