Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate IDGenerator_.java #35

Open
jas34 opened this issue Jul 15, 2023 · 0 comments
Open

Deprecate IDGenerator_.java #35

jas34 opened this issue Jul 15, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jas34
Copy link
Owner

jas34 commented Jul 15, 2023

While working on the PR with @vivianzheng404 on the PR - #32, we realised that the conductor has changed IDGenerator from static class to a spring bean (Ref Netflix/conductor#2910). For release-3.0.0 we have decided to go with a static class adapted in scheduledwf as IDGenerator_.java (at scheduledwf-core/src/main/java/io/github/jas34/scheduledwf/utils/IDGenerator_.java).
This ticket will deprecate IDGenerator_ and we will move to consume IDGenerator bean from conductor-core. This ticket is being opened to implement after release-3.0.0.
Refer to conversation - https://github.com/jas34/scheduledwf/pull/32/files#r1250839746
@jas34 jas34 added enhancement New feature or request help wanted Extra attention is needed labels Jul 15, 2023
@jas34 jas34 mentioned this issue Jul 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jas34