Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support far global variable accesses in ARM #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarranz
Copy link
Collaborator

@sarranz sarranz commented Oct 2, 2024

Closes #619. I assume that ADR instructions are only generated for accesses to the data section, which seems to be true. I don't think it's a robust solution, but I don't see how to do it otherwise. Also, I believe we can't tell whether we can perform the relative access or not, so as to generate two instructions only when needed. The other options discussed in the issue didn't work, and I can't explain why.

@bgregoir
Copy link
Contributor

bgregoir commented Oct 8, 2024

I don't know what to think about this.
In one side it maybe is better than nothing.
On the other this is not certified.
Maybe you should merge this and then do the proper patch.
Any opinion on that ?

@sarranz
Copy link
Collaborator Author

sarranz commented Oct 8, 2024

I did this because I thought we couldn't verify much about this, but you're right (as usual :)). I guess what you have in mind is to define the MOV lower and upper as extra ops? If so, I can do it, no problem. But I can't assure when, so I leave the question about merging or waiting to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM - dealing with large programs / global arrays - invalid constant (XXXX) after fixup
2 participants