feat: R syntax highlighter in analysis panel controls #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shun2wang
force-pushed
the
rSyntaxHighlighter
branch
2 times, most recently
from
7c0e8a1
to
f9af432
Compare
JorisGoosen
requested review from
RensDofferhoff
and removed request for
boutinb and
JorisGoosen
|
Hey @shun2wang me and bruno are on vacation but I had a quick look at the code. This looks fine. I do not however have the time nor machines here to test. Perhaps @RensDofferhoff can take this task upon himself? |
JorisGoosen
requested review from
JorisGoosen
and removed request for
RensDofferhoff
JorisGoosen
force-pushed
the
rSyntaxHighlighter
branch
from
f9af432
to
c49f788
Compare
JorisGoosen
approved these changes
Sep 5, 2024
|
Very nice! With the additions I made we now have rsyntax highlighting, or something like it, in filterwindow, computed columnwindow and the rcommander as well! |
JorisGoosen
pushed a commit
that referenced
this pull request
Sep 30, 2024
* init r language highlighter * rename lavaan bound contorls to r lang * add special number case * also enable highlighter for R syntax text area * fix strings format and also styles * add rsyntaxhighlighter quickitem, to make non jasp textareas highlighted easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is fine, but I override the lavaan syntax behavior since it's also a subset of the R syntax.
With these PR #5474 and #5102, we can take the user experience of R syntax in JASP to the next level.