Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis constraint error should not be closeable #5572

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Jun 18, 2024

When an error occurs because for example a variable does not have enough levels, this error should not be closeable: the user must remove it from the VariablesList first. As long such an error exists, the analysis cannot be run.

When an error occurs because for example a variable does not have enough levels, this error should not be closeable: the user must remove it from the VariablesList first. As long such an error exists, the analysis cannot be run.
@boutinb boutinb requested a review from JorisGoosen June 18, 2024 12:44
@JorisGoosen
Copy link
Contributor

JorisGoosen commented Jun 18, 2024

Looks real good but if I press refresh it still reruns the analysis

As in Cmd/ctrl+R

@boutinb
Copy link
Contributor Author

boutinb commented Jun 18, 2024

Looks real good but if I press refresh it still reruns the analysis

As in Cmd/ctrl+R

OK, I prevent now refreshing if the analysis has an error.

@JorisGoosen JorisGoosen merged commit ef363d9 into jasp-stats:development Jun 18, 2024
1 check passed
@JorisGoosen
Copy link
Contributor

my first smartphonemerge ever ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants