Setting computed column definition should wait for all property changes #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ComputeColumnWindow is initialized from a Json string. This string gets all information to build the drag-and-drop QML window. The signal that this Json string has changed should be emitted when all changes has been made: this is important especially when the chosen column is changed and all properties are suddenly changed. So we must wait for all properties to be changed, before emitting the json change: this is done by connecting the signal with QueuedConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scale Computed column using drag-and-drop scale variables.
Click on a nominal column.
Click the header of the computed column: the drag-and-drop window is erroneous
It is because it thinks that the computed column is still a nominal
The ComputeColumnWindow is initialized from a Json string. This string gets all information to build the drag-and-drop QML window. The signal that this Json string has changed should be emitted when all changes has been made: this is important especially when the chosen column is changed and all properties are suddenly changed. So we must wait for all properties to be changed, before emitting the json change: this is done by connecting the signal with QueuedConnection.