Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secret-service version #90

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

calixtus
Copy link

There seem to be some problems with the old version of secret-service and dbus we ran into (see swiesend/secret-service#31). Hopefully using the latest version of secret-service fixes them.

@koppor
Copy link

koppor commented Jul 17, 2023

On that note, would it be possible to enable dependabot on this repository?

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -33.34% ⚠️

Comparison is base (8e296a4) 79.26% compared to head (82b5022) 45.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #90       +/-   ##
=============================================
- Coverage     79.26%   45.93%   -33.34%     
+ Complexity       92       53       -39     
=============================================
  Files            14       14               
  Lines           381      381               
  Branches         41       41               
=============================================
- Hits            302      175      -127     
- Misses           50      195      +145     
+ Partials         29       11       -18     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rexhoffman
Copy link
Member

@koppor looks like this needs more than a simple dependency upgrade, unfortunately.

@calixtus
Copy link
Author

calixtus commented Aug 16, 2023

I was not yet able to reproduce the problem with the ci on my machine.
It's obviously not about the java version, as both jdk 11 and jdk 17 fail on linux, but also jdk 11 on win. I will try later again.

About the version: Official support for jdk 11 runs out in september. The newer version of secret service is build with jdk 17. Do you still want to test with jdk 11?

@rexhoffman
Copy link
Member

already updated when cutting 1.0.4 but merging for bonus points.

@rexhoffman rexhoffman merged commit 5ccf275 into javakeyring:master Aug 30, 2023
3 of 8 checks passed
@calixtus calixtus deleted the bump_secret_service branch August 30, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants