Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix linuxes, testing in CI #91

Merged
merged 0 commits into from
Sep 24, 2023
Merged

attempt to fix linuxes, testing in CI #91

merged 0 commits into from
Sep 24, 2023

Conversation

rexhoffman
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +25.72% 🎉

Comparison is base (090f04f) 45.93% compared to head (fcb06de) 71.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #91       +/-   ##
=============================================
+ Coverage     45.93%   71.65%   +25.72%     
- Complexity       53       82       +29     
=============================================
  Files            14       14               
  Lines           381      381               
  Branches         41       41               
=============================================
+ Hits            175      273       +98     
+ Misses          195       80      -115     
- Partials         11       28       +17     
Files Changed Coverage Δ
...ithub/javakeyring/internal/kde/KWalletBackend.java 16.66% <100.00%> (+16.66%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koppor
Copy link

koppor commented Sep 5, 2023

Jsut as note, version 1.7.0 of secret-service runs fine on current master:

image

@koppor
Copy link

koppor commented Sep 5, 2023

Oh, in 1.8.0-jdk17, KDE stopped working, but Gnome remains working:

image

@koppor
Copy link

koppor commented Sep 5, 2023

1.8.1 IMHO will never work: DBUS creates an abstract socket, which cannot be handled by the native Java socket library. See swiesend/secret-service#43 (comment) for details.

I will file a PR.

@koppor
Copy link

koppor commented Sep 8, 2023

Some hints included at #92 (comment)

@rexhoffman rexhoffman force-pushed the fix_linuxes branch 22 times, most recently from da681b5 to 6b680c3 Compare September 24, 2023 22:54
@rexhoffman rexhoffman merged commit fcb06de into master Sep 24, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants