Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strauss hack jt #17

Open
wants to merge 48 commits into
base: strauss-hack
Choose a base branch
from

Commits on Jul 9, 2024

  1. fix: make standalone work with matplotlib >= 3.9.0

    Unclear what the real underlying issue is. Code comments give a
    possible explanation.
    maartenbreddels committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f4fd992 View commit details
    Browse the repository at this point in the history
  2. Merge pull request spacetelescope#2944 from maartenbreddels/fix_matpl…

    …otlib_standalone_compat
    
    fix: make standalone work with matplotlib >= 3.9.0
    pllim authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6e2826f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e65237f View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    2201752 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. support exporting a plot from an unopened/inactive plugin (spaceteles…

    …cope#2934)
    
    * support exporting a plot from an unopened/inactive plugin
    * prevent clearing plot selection (under most conditions)
    kecnry authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    18bb83e View commit details
    Browse the repository at this point in the history
  2. Merge pull request spacetelescope#3080 from bmorris3/link-nbs-to-stable

    Sync notebook github links in HTML docs to the git commit used to build them
    bmorris3 authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3e7aade View commit details
    Browse the repository at this point in the history
  3. BUG: Specviz to respect local_path when provided (spacetelescope#3081)

    * BUG: Specviz to respect local_path and timeout when provided
    pllim authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8e2249b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73e54d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    59b179e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Update jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_ex…

    …traction.py
    
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    bmorris3 and kecnry authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    39ac1c4 View commit details
    Browse the repository at this point in the history
  2. Catalogs plugin results table (spacetelescope#2915)

    
    ---------
    
    Co-authored-by: Katherine Carver <kcarver@osx-summer2401.stsci.edu>
    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
    5 people authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    23b3edd View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    5bea741 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b13c3bc View commit details
    Browse the repository at this point in the history
  3. fixes for linkcheck test

    bmorris3 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6b7f233 View commit details
    Browse the repository at this point in the history
  4. Merge pull request spacetelescope#3097 from bmorris3/exclude-subsets-…

    …orientation-dropdown
    
    Exclude subsets from WCS-only layer filter
    bmorris3 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4fe79a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    f35af23 View commit details
    Browse the repository at this point in the history
  2. Improve overwrite warning behavior in export (spacetelescope#3094)

    * Use normalize_filename and overwrite_warn for plugin plots
    
    * Clear overwrite warning overlay after confirming
    
    * Changelog
    
    * Codestyle
    rosteen authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    df59fd7 View commit details
    Browse the repository at this point in the history
  3. Markers: Save to CSV (spacetelescope#3089)

    * Markers: Save to CSV
    
    * Mark block as uncovered for coverage
    
    * Remove unused entries from _dict
    
    * Update CHANGES.rst
    
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    
    ---------
    
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    pllim and kecnry authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dfb4bfa View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Create private method for importing spectral region objects (spacetel…

    …escope#2941)
    
    * Create private method for importing spectral region objects
    
    * Address review comments
    
    * Add tests for list of modes and single SpectralRegion
    
    * Fix style
    javerbukh authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5c92eae View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    3279bcf View commit details
    Browse the repository at this point in the history
  2. Update docs/sample_notebooks.rst

    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    bmorris3 and kecnry authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3d54bd7 View commit details
    Browse the repository at this point in the history
  3. Merge pull request spacetelescope#3098 from bmorris3/fix-roman-parser…

    …-test
    
    Fix for Imviz parser romandeps test after update to defaults
    bmorris3 authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    eaa720e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e34fcf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge pull request spacetelescope#3109 from bmorris3/back-to-dev-v3.10.4

    Changelog update for release of v3.10.3
    bmorris3 authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    da26504 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1ae0f2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request spacetelescope#3088 from bmorris3/cubeviz-default-…

    …extract
    
    Bugfix for flux unit conversion in spectral cubes
    bmorris3 authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    22ed4cf View commit details
    Browse the repository at this point in the history
  4. expanded support of SB/Flux translations (spacetelescope#2940)

    * UI functioning unit conversion, need to reconcile tests
    
    * update syntax, remove unnecessary logic
    
    * tests now pass, API functionality improved
    
    * add additional equivalencies for coords info
    
    * first pass at disabling specviz translations
    
    * Remove dev flag, consolidate untranslatable units, multi-config support, styling changes
    
    * Refactor moment map unit conversion
    to not require spectrum, so nothing to centralize now.
    
    Fix devdeps
    
    Simplify flux_conversion logic
    and other minor fixes. Add flux conversion tests.
    
    Clarify which one should be reverted
    in the future
    
    * Remove SB/flux conversion for moment map
    because moment map always in SB
    
    * add os import
    
    * remove duplicate import from rebase
    
    * reconcile tests, change hints/docs, handle dimensionless case
    
    * emit GlobalDisplayUnitChanged msg when toggling SB<>flux
    
    * resolve most tests
    
    * temporarily remove translation message
    
    * add comments, reenable global display message, resolve tests
    
    * force sb unit for line flux test
    
    * add comments, clarify naming, add case handling for args
    
    * remove args and loop, replaced with msg
    
    * consolidate 2 translator functions into 1, consolidate _translate and _on_flux_unit_changed
    
    * address test failures
    
    * update marks.py equivalencies, resolving UnitConversion errors
    
    * make sure not only translation equivalencies are in marks.py but also conversions
    
    * add test coverage
    
    * use astropy units, small logic tweaks, cache untranslatable units
    
    * technical review changes
    
    * add warning message in tray if PIXAR_SR not present in FITS header
    
    * second pass at technical changes
    
    * move flux_unit checks to beginning of _on_flux_unit_changed
    
    * change _unit to flux.unit
    
    ---------
    
    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    3 people authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    143cd8d View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. TST: Also run slow test in non-dev env, fix Catalog Search bug (space…

    …telescope#3101)
    
    * TST: Also run slow test in non-dev env
    
    * BUG: Fix table I/O in Catalog Search
    
    * ID as string always
    
    * Force ID to be always str even from file
    pllim authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6fb47ab View commit details
    Browse the repository at this point in the history
  2. MNT: Remove unused astropy version check, update doctest (spacetelesc…

    …ope#3114)
    
    * MNT: Remove unnecessary astropy version checks
    
    * TST: Update model doctest
    pllim authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3de1b08 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Update model fit result units after toggling flux/surface brightness (s…

    …pacetelescope#3113)
    
    * Enabling model fitting results to convert between flux and surface brightness
    
    * Switch to using selected_obj, clean up pixel scale retrieval
    
    * Changelog
    
    * Don't store pixel scale factor
    
    * Fix missing variable
    
    * Update test value due to updated pixel scale factor
    rosteen authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dc2186e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Generalize cube extract (spacetelescope#2939)

    * generalize use of term "spectrum"
    * move code to allow importing slice mixins without circular imports
    * is_slice_indicator filter for extract results instead of relying on a spectrum viewer existing and being set
    * attach marks to slice_indicator_viewers[0] instead of spectrum_viewer (temporarily to just the first instance, later we'll make this more flexible to allow any number of slice indicator viewers)
    * remove reliance on loaded_flux_cube
    * rename (internal) spectral_cube -> cube
    * generalize logic for setting disabled_msg
    * generalize internal marks names
    * generalize some internal traitlet names
    * update disabled message to specify cube
    * update tests for renamed marks/method
    * generalize logic within live-preview and extract
    * allow skipping wavelength-dependence
    * hide aperture masking method for entire cube and no bg
    * fix (and allow disabling) bg export
    * fix updating live preview on change to subset
    * skip updating marks if not tray instance
    kecnry authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    682e302 View commit details
    Browse the repository at this point in the history
  2. TST: Fix tests downloading data into source dir.

    MNT: Remove unnecessary astropy check.
    pllim committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e26b9ef View commit details
    Browse the repository at this point in the history
  3. "Imviz Line Profiles (XY)" renamed to "Image Profiles (XY)" (spacetel…

    …escope#3121)
    
    * remove "Imviz" from "Line Profiles XY" plugin name with deprecation
    
    * changelog entry
    kecnry authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1a210d1 View commit details
    Browse the repository at this point in the history
  4. Update the mouse over units by listening to the unit-conversion plugin (

    spacetelescope#2931)
    
    * Respond to changed unit and display on the UI
    
    * Convert all sb<>sb units listed in the dropdown menu
    
    * Use the default current unit from the cube
    
    * Apply only for relevant configs
    
    * Update current_unit setting logic
    
    * Fix failing tests
    
    * Add tests
    
    * Add a changelog
    
    * Move conversion logic to utils
    
    * Move the conversion to utils
    
    * Pass when unable to convert
    
    * Update tests
    
    * Update based on the feedback
    
    * Only subscribe to cubeviz
    
    * Check for equivalency rather than image dimension
    
    * Refactor conversion logic
    
    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    
    * Rename unit and broadcast 'sb' as part of msg
    
    * Code style
    
    ---------
    
    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    haticekaratay and pllim authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a126296 View commit details
    Browse the repository at this point in the history
  5. Merge pull request spacetelescope#3122 from pllim/moar-code-cleanup

    TST: Fix tests downloading data into source dir, MNT: Remove unnecessary astropy check
    pllim authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ec0720b View commit details
    Browse the repository at this point in the history
  6. Cubeviz to use wcs1d-fits from specutils

    to write out fitted cube.
    
    This uses astropy/specutils#1051
    pllim committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9d46233 View commit details
    Browse the repository at this point in the history
  7. Merge pull request spacetelescope#2094 from pllim/cubeviz-use-wcs1d-fits

    Cubeviz to use wcs1d-fits from specutils to write out fitted cube
    pllim authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5a020cc View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    5a74cd6 View commit details
    Browse the repository at this point in the history
  2. Fix cube fit toggle with spectral subset selected (spacetelescope#3123)

    * Avoid checking selected_obj before it's available
    
    * Changelog
    
    * Added a test that fails on main
    rosteen authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    09c3cc6 View commit details
    Browse the repository at this point in the history
  3. Create audified cube and use with spectrum at spaxel tool

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6049d9a View commit details
    Browse the repository at this point in the history
  4. Add Sonify Data plugin and connect to spectrum per spaxel tool

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    627a34f View commit details
    Browse the repository at this point in the history
  5. Fix errors

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9e98b32 View commit details
    Browse the repository at this point in the history
  6. Try moving code to mixin

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e6d52b4 View commit details
    Browse the repository at this point in the history
  7. Move code to viewers.py

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0080b2f View commit details
    Browse the repository at this point in the history
  8. Remove print statements

    javerbukh authored and James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4b01304 View commit details
    Browse the repository at this point in the history
  9. Patches:

    - Fix sigcube alignment with other cubes [get rid of transpose]
    - Add percentile cut option that enables some rough feature isolation without full continuum subtraction
    - Protect against cubes w/NaNs
    James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    505f73f View commit details
    Browse the repository at this point in the history
  10. fix np import

    James Trayford committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    89d6fff View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. add audio frequency range choice and equal loudness normalisation opt…

    …ions
    James Trayford committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5c67736 View commit details
    Browse the repository at this point in the history