context: Fix directory leakage for snapshots contexts

Fix an error preventing the auto-unpacked snapshot files to be deleted.
Add a unit-test to expose the issue.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>

pkg/context/context.go

@@ -116,7 +116,7 @@ func (ctx *Context) Teardown() error {
 		// then it is also in charge of the cleanup.
 		return nil
 	}
-	return snapshot.Cleanup(ctx.SnapshotRoot)
+	return snapshot.Cleanup(ctx.Chroot)
 }
 
 func (ctx *Context) Warn(msg string, args ...interface{}) {

pkg/context/context_test.go

@@ -0,0 +1,42 @@
+//
+// Use and distribution licensed under the Apache license version 2.
+//
+// See the COPYING file in the root project directory for full text.
+//
+
+package context_test
+
+import (
+	"os"
+	"testing"
+
+	"github.com/jaypipes/ghw/pkg/context"
+	"github.com/jaypipes/ghw/pkg/option"
+)
+
+const (
+	testDataSnapshot = "../snapshot/testdata.tar.gz"
+)
+
+// nolint: gocyclo
+func TestSnapshotContext(t *testing.T) {
+	ctx := context.New(option.WithSnapshot(option.SnapshotOptions{
+		Path: testDataSnapshot,
+	}))
+
+	var uncompressedDir string
+	err := ctx.Do(func() error {
+		uncompressedDir = ctx.Chroot
+		return nil
+	})
+
+	if len(uncompressedDir) == 0 {
+		t.Fatalf("Expected the uncompressed dir path to not be empty")
+	}
+	if err != nil {
+		t.Fatalf("Expected nil err, but got %v", err)
+	}
+	if _, err = os.Stat(uncompressedDir); !os.IsNotExist(err) {
+		t.Fatalf("Expected the uncompressed dir to be deleted: %s", uncompressedDir)
+	}
+}