uplift Go, dependencies and action runners #369
Conversation
Uplifts our Go version to 1.21, our pcidb and cobra dependencies to the latest version and uplifts our Github action runners appropriately. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
| @@ -1,22 +1,22 @@ | |||
| module github.com/jaypipes/ghw | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
do we need any feature of go >= 1.20, or do one of our uplifted deps?
There was a problem hiding this comment.
@ffromani no, not particularly. I was just keeping us up to date with more modern Go :)
There was a problem hiding this comment.
I'm a fan of keeping backward compatibility as much as possible for library code, but I don't have any real objection here so let's bump it.
Perhaps next time let's try to be a tad more conservative for the sake of making life of the consumers of ghw easier
| @@ -22,6 +22,7 @@ jobs: | |||
| github.com:443 | |||
| api.github.com:443 | |||
| proxy.github.com:443 | |||
| proxy.golang.org:443 | |||
There was a problem hiding this comment.
why is this needed? I can't recall when the proxy was introduced but I seem to recall it was prior to 1.20
There was a problem hiding this comment.
@ffromani an egress forbidden error transiently shows up in some GH action workflow runs -- perhaps when the action runner does not have something in its cache? Adding this addresses those spurious failures.
There was a problem hiding this comment.
I have no major objections here so I guess we can move on
Uplifts our Go version to 1.21, our pcidb and cobra dependencies to the latest version and uplifts our Github action runners appropriately.